Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sunbeam][tests] Add product tests for sunbeam #3837

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arif-ali
Copy link
Member

@arif-ali arif-ali commented Nov 14, 2024

  • Move the juju tests now to sunbeam, now that we deploy using juju here, no
    need to mock the configuration files.
  • Include plugins that are associated here
    • kubernetes
    • ovn_host
    • juju

Related: #3622


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@arif-ali
Copy link
Member Author

This is an initial preview of the work on new stageone tests for sunbeam, Canonical's new OpenStack

Need to add some more stuff, but wanted to fer an initial pass from everyone

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3837
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali arif-ali force-pushed the sos-arif-sunbeam-func-tests branch 7 times, most recently from 362a3f7 to 0a746f3 Compare November 15, 2024 09:31
@arif-ali
Copy link
Member Author

The failure is known, I forgot to bring that fix back onto my system, from my test system.

All in all working ok, I think; I'll crack on to add other tests that we need, and close to a final update next week.

e2-medium-4 machine taking 1h 5, which is bigger and at least 3 times longer than the other Integration test, hopefully the slowness is not of concern

@arif-ali arif-ali force-pushed the sos-arif-sunbeam-func-tests branch from 0a746f3 to f1b9359 Compare November 15, 2024 14:54
# ]
#
# for the_cmd in cmds_to_check:
# self.assertFileCollected(f'sos_commands/juju/{the_cmd}')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left this here, as we need to add this to functional tests. We need to now figure out what happened in my previous PR on adding these commands, as we should be capturing this.

Once that is resolved, we can enable this section.

@arif-ali arif-ali marked this pull request as ready for review November 15, 2024 16:28
@arif-ali
Copy link
Member Author

Bringing this back as draft, as new Canonical K8s is going to be used, and I don't want future runs to start suddenly failing

@arif-ali arif-ali marked this pull request as draft November 18, 2024 10:50
@arif-ali arif-ali added the Canonical Eng Canonical Engineering for review label Nov 22, 2024
@arif-ali arif-ali force-pushed the sos-arif-sunbeam-func-tests branch from f1b9359 to 3281003 Compare December 5, 2024 14:17
@arif-ali arif-ali removed the Canonical Eng Canonical Engineering for review label Dec 5, 2024
@arif-ali
Copy link
Member Author

arif-ali commented Dec 5, 2024

hmm, took more than 1200 seconds to get a sos report.

In my lab it took <900 seconds (see below), maybe I need to increase the size of the VM on GCE to get better performance 🤷🏽

 (34/55) tests/product_tests/sunbeam/sunbeam_tests.py:SunbeamBasicTest.test_plugins_ran: STARTED
 (34/55) tests/product_tests/sunbeam/sunbeam_tests.py:SunbeamBasicTest.test_plugins_ran:  PASS (885.91 s)
 (35/55) tests/product_tests/sunbeam/sunbeam_tests.py:SunbeamBasicTest.test_sunbeam_keys_skipped: STARTED
 (35/55) tests/product_tests/sunbeam/sunbeam_tests.py:SunbeamBasicTest.test_sunbeam_keys_skipped:  PASS (0.09 s)

* Move the juju tests now to sunbeam, now that we deploy using juju here, no
  need to mock the configuration files.
* Include plugins that are associated here
  - kubernetes
  - ovn_host
  - juju

Related: sosreport#3622

Signed-off-by: Arif Ali <[email protected]>
@arif-ali arif-ali force-pushed the sos-arif-sunbeam-func-tests branch from 3281003 to 1b82d01 Compare December 5, 2024 20:20
@arif-ali
Copy link
Member Author

arif-ali commented Dec 5, 2024

Cirrus + gce is too unstable for openstack to be mocked. I'm ditching this.

@arif-ali arif-ali closed this Dec 5, 2024
@arif-ali
Copy link
Member Author

arif-ali commented Dec 6, 2024

After speaking to Engineering, it seems like a part of the product changed that could be causing failures. 2 changes were made, one to go to LTS of juju, and the Canonical k8s, so once this stabilises, I'll try this again

@arif-ali arif-ali reopened this Dec 6, 2024
@arif-ali arif-ali added the Canonical Eng Canonical Engineering for review label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects ubuntu Canonical Eng Canonical Engineering for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants