Add new section fstype section under hardware devices.

[lherbolt]

As discussed in the #3502 adding new section under _get_hardware_devices(). Please review it.

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname [email protected]?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3538
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3538
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[jcastill]

lgtm
just tested it as well and no issues with lots of fs and empty first FSTYPE, nicely dealt with

[pmoravec]

In general, I am not against maintaining centrally a next type of devices. Keeping a dict per fstype - I dont see much use case for the "per FS type" in particular (which does not mean there is a legitimate use case for it).

[lherbolt]

In general, I am not against maintaining centrally a next type of devices. Keeping a dict per fstype - I dont see much use case for the "per FS type" in particular (which does not mean there is a legitimate use case for it).

The fstype will not just enumerate the fstypes but also linux_raid_member or LVM2_member. The complete list can be obtained from blkid -k, not only the filesystems plugins could use this, but the md and lvm plugin as well and probably some others too. The fstype might be bit misleading but I kept the name to match the lsblk output.

[pmoravec]

ACK, then. Thanks for explaining,

Not sure with the device key name (fstype) as I got confused by it, but if there wont be an objection from anybody else or no better name, I am OK with it.

[TurboTurtle]

Minor comments, code overall looks good.

[TurboTurtle]

Can we not be more specific here? If not, I think we should just put ext rather than slashed version possibilities.

[lherbolt]

ACK will change it to ext there is no conflict with other blkid types

blkid -k | grep ext
xfs_external_log
ext4dev
ext4
ext3
ext2

[lherbolt]

Left it as ext4