Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hook for autogeneration code #41

Merged
merged 1 commit into from
May 5, 2014
Merged

Conversation

mk270
Copy link
Contributor

@mk270 mk270 commented May 5, 2014

this gives us the option of making the autogeneration much less brittle

samaaron added a commit that referenced this pull request May 5, 2014
add hook for autogeneration code
@samaaron samaaron merged commit feda5a1 into sonic-pi-net:master May 5, 2014
@samaaron
Copy link
Collaborator

samaaron commented May 5, 2014

Ah cool, neat idea - I'll play around with this. Looks like it'll also get round the annoyance of not being able to put line breaks in the HTML strings.

@mk270
Copy link
Contributor Author

mk270 commented May 5, 2014

My idea is call the ruby stuff from a script in ..../qt, and have it dump sensibly-named files in .../qt/help, and then use this hook to pull them in at compile-time.

Separately, this machinery wants to be in a file outside mainwindow.cpp, to minimise cockups on the "git diff" / "git commit" front

@samaaron
Copy link
Collaborator

samaaron commented May 5, 2014

Agreed.

I'm also unsure that this doc system is the actual way to go. It's just what I managed to be able to knock up in a few days with minimal Qt knowledge. I'd much prefer it to be indexable and for the structured parts be more elegantly formatted than styleless HTML. I'd love to use table structures with expansion where appropriate. Baby steps first though :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants