Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mainwindow.cpp is littered with literal strings #28

Closed
GeorgBisseling opened this issue Oct 14, 2013 · 1 comment
Closed

mainwindow.cpp is littered with literal strings #28

GeorgBisseling opened this issue Oct 14, 2013 · 1 comment

Comments

@GeorgBisseling
Copy link

use some constants
@samaaron
Copy link
Collaborator

samaaron commented May 3, 2014

Not sure why this is a real issue? Is there some performance/memory leak issues it will cause?

@samaaron samaaron closed this as completed May 3, 2014
@helgeras helgeras mentioned this issue Jun 16, 2015
Closed
@sentinelburo sentinelburo mentioned this issue May 31, 2020
Closed
@MusheAbdulHakim MusheAbdulHakim mentioned this issue Jan 9, 2021
Closed
@xtramo xtramo mentioned this issue Jun 8, 2021
Closed
@yerpdave yerpdave mentioned this issue Dec 11, 2021
Closed
samaaron added a commit that referenced this issue Feb 10, 2022
@samaaron
Squashed 'app/external/sp_midi/' changes from 6cdd94525..834fe552b
f7866da 
834fe552b Merge pull request #27 from sonic-pi-net/catch-sendMessage-exceptions
34d6cb763 Merge pull request #28 from sonic-pi-net/rtmidi-5
e4d31dd55 rtmidi - include BEAM v24 headers for Windows builds
e60fa869b CI - handle Erlang dep w/ same method used in Sonic Pi
d738b9565 External Libs - upgrade RtMidi to v5.0.0
94b3880c3 Update midiout.cpp
aea10f081 Remove hotplug thread and trigger refresh from erl (#26)

git-subtree-dir: app/external/sp_midi
git-subtree-split: 834fe552b13c5c1a196174989ea805720c65b62a
@GhostShadow0316 GhostShadow0316 mentioned this issue Oct 31, 2022
Open
This was referenced Sep 11, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samaaron @GeorgBisseling