-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dhcp_relay] DHCPv6 automatic test #3767
[dhcp_relay] DHCPv6 automatic test #3767
Conversation
Add DHCPv6 PTF test Add infrastructure for generating minigraph xml file with DHCPv6 servers Change-Id: I8ae4feea5d47bf512c84a160757288a5d3376cf5 Signed-off-by: Shlomi Bitton <[email protected]>
Add a condition to check if 'dhcpv6_servers' is defined to avoid an exception Change-Id: I71d6a3144d5c77719dcfa1077ec167b7746ff8ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not merge this PR until sonic-net/sonic-buildimage#7772 is merged.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
test_dhcp_relay_default is failing since PR sonic-net/sonic-buildimage#7772 is not merged yet. |
build image pr has been merged, please retest when the image is built. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@lguohan Test passed with built image including the buildimage PR. |
@wangxin can we proceed with the merge? |
Hi @wangxin - could you please review and approve asap, this is needed in 202106 release |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
… dhcpv6 relay test Add ansible group variable "dhcpv6_servers" for the new dhcpv6 relay test PR sonic-net#3767 introduced dhcpv6 relay test script that needs variable "dhcpv6_servers" predefined in ansible group vars visible to DUTs. This PR is to define the "dhcpv6_server" group variable in 'ansible/group_vars/str/str.yml' and 'ansible/group_vars/str2/str2.yml' which are used by our starlab DUTs. Signed-off-by: Xin Wang <[email protected]>
What is the motivation for this PR? Add DHCPv6 automatic test infrastructure and PTF test. How did you do it? * Enhance the minigraph_facts.py and minigraph_dpg.j2 to support DHCPv6 instances. * Add DHCPv6 servers to lab.yml file. * This will deploy on a DUT DHCPv6 servers on regression run. * Develop a test with 3 test cases: * test_dhcp_relay_default * test_dhcp_relay_after_link_flap * test_dhcp_relay_start_with_uplinks_down * Develop a PTF runner test to simulate the traffic according to the test case from sonic-mgmt. How did you verify/test it? Use testbed-cli.sh to generate and deploy a minigraph with DHCPv6 instances on a switch. Run the test. This test depends on PR: [dhcp_relay] DHCP relay support for IPv6 sonic-buildimage#7772 Supported testbed topology if it's a new test case? T0 Signed-off-by: Shlomi Bitton <[email protected]>
Description of PR
Summary:
DHCPv6 infrastructure and automatic test.
Type of change
Approach
What is the motivation for this PR?
Add DHCPv6 automatic test infrastructure and PTF test.
How did you do it?
Enhance the minigraph_facts.py and minigraph_dpg.j2 to support DHCPv6 instances.
Add DHCPv6 servers to lab.yml file.
This will deploy on a DUT DHCPv6 servers on regression run.
Develop a test with 3 test cases:
Develop a PTF runner test to simulate the traffic according to the test case from sonic-mgmt.
How did you verify/test it?
Supported testbed topology if it's a new test case?
T0