Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dhcp_relay] DHCPv6 automatic test #3767

Merged
merged 2 commits into from
Aug 4, 2021
Merged

[dhcp_relay] DHCPv6 automatic test #3767

merged 2 commits into from
Aug 4, 2021

Conversation

shlomibitton
Copy link
Contributor

Description of PR

Summary:
DHCPv6 infrastructure and automatic test.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Add DHCPv6 automatic test infrastructure and PTF test.

How did you do it?

Enhance the minigraph_facts.py and minigraph_dpg.j2 to support DHCPv6 instances.
Add DHCPv6 servers to lab.yml file.
This will deploy on a DUT DHCPv6 servers on regression run.
Develop a test with 3 test cases:

  • test_dhcp_relay_default
  • test_dhcp_relay_after_link_flap
  • test_dhcp_relay_start_with_uplinks_down

Develop a PTF runner test to simulate the traffic according to the test case from sonic-mgmt.

How did you verify/test it?

Supported testbed topology if it's a new test case?

T0

Shlomi Bitton added 2 commits July 11, 2021 17:14
Add DHCPv6 PTF test
Add infrastructure for generating minigraph xml file with DHCPv6 servers

Change-Id: I8ae4feea5d47bf512c84a160757288a5d3376cf5
Signed-off-by: Shlomi Bitton <[email protected]>
Add a condition to check if 'dhcpv6_servers' is defined to avoid an exception

Change-Id: I71d6a3144d5c77719dcfa1077ec167b7746ff8ee
@shlomibitton shlomibitton requested a review from a team as a code owner July 11, 2021 14:16
Copy link
Collaborator

@wangxin wangxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge this PR until sonic-net/sonic-buildimage#7772 is merged.

@wangxin
Copy link
Collaborator

wangxin commented Jul 12, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shlomibitton
Copy link
Contributor Author

test_dhcp_relay_default is failing since PR sonic-net/sonic-buildimage#7772 is not merged yet.

@lguohan
Copy link
Contributor

lguohan commented Jul 16, 2021

build image pr has been merged, please retest when the image is built.

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shlomibitton
Copy link
Contributor Author

@lguohan Test passed with built image including the buildimage PR.

@shlomibitton
Copy link
Contributor Author

shlomibitton commented Jul 20, 2021

@wangxin can we proceed with the merge?
sonic-net/sonic-buildimage#7772 is merged and the test passed.

@shlomibitton shlomibitton requested a review from wangxin July 25, 2021 07:15
@anshuv-mfst
Copy link

Hi @wangxin - could you please review and approve asap, this is needed in 202106 release

@lguohan
Copy link
Contributor

lguohan commented Aug 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin wangxin merged commit 6a2e2ff into sonic-net:master Aug 4, 2021
bingwang-ms pushed a commit to bingwang-ms/sonic-mgmt that referenced this pull request Aug 18, 2021
… dhcpv6 relay test

Add ansible group variable "dhcpv6_servers" for the new dhcpv6 relay test

PR sonic-net#3767 introduced dhcpv6 relay test script
that needs variable "dhcpv6_servers" predefined in ansible group vars visible to DUTs.

This PR is to define the "dhcpv6_server" group variable in 'ansible/group_vars/str/str.yml'
and 'ansible/group_vars/str2/str2.yml' which are used by our starlab DUTs.

Signed-off-by: Xin Wang <[email protected]>
@shlomibitton shlomibitton deleted the shlomi_community_dhcpv6_relay_test branch September 5, 2021 08:39
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
What is the motivation for this PR?
Add DHCPv6 automatic test infrastructure and PTF test.

How did you do it?
* Enhance the minigraph_facts.py and minigraph_dpg.j2 to support DHCPv6 instances.
* Add DHCPv6 servers to lab.yml file.
* This will deploy on a DUT DHCPv6 servers on regression run.
* Develop a test with 3 test cases:
  * test_dhcp_relay_default
  * test_dhcp_relay_after_link_flap
  * test_dhcp_relay_start_with_uplinks_down
* Develop a PTF runner test to simulate the traffic according to the test case from sonic-mgmt.

How did you verify/test it?
Use testbed-cli.sh to generate and deploy a minigraph with DHCPv6 instances on a switch.
Run the test.
This test depends on PR: [dhcp_relay] DHCP relay support for IPv6 sonic-buildimage#7772

Supported testbed topology if it's a new test case?
T0

Signed-off-by: Shlomi Bitton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants