Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SFT-1598]: Long form handles #1655

Merged
merged 3 commits into from
Nov 21, 2024
Merged

[SFT-1598]: Long form handles #1655

merged 3 commits into from
Nov 21, 2024

Conversation

seandelaney
Copy link
Contributor

Fixes #1644

@seandelaney seandelaney changed the title fix(SFT-1598): long form handles [SFT-1598]: Long form handles Nov 21, 2024
@seandelaney seandelaney added the fix Fix an issue label Nov 21, 2024
@kjmartens kjmartens self-requested a review November 21, 2024 21:39
kjmartens
kjmartens previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@kjmartens kjmartens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed it works nicely 👌

@kjmartens kjmartens dismissed stale reviews from gustavs-gutmanis and themself via 3616eeb November 21, 2024 21:41
@kjmartens kjmartens merged commit 32fe602 into v5 Nov 21, 2024
4 checks passed
@kjmartens kjmartens deleted the fix/SFT-1598-long-form-handles branch November 21, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjmartens kjmartens kjmartens left review comments

@gustavs-gutmanis gustavs-gutmanis gustavs-gutmanis left review comments

Assignees
No one assigned
Labels
fix Fix an issue
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Craft 4 to 5 migration fails
3 participants
@seandelaney @gustavs-gutmanis @kjmartens