Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission doen't get send to all receipients because template mode is switched #1594

Closed
WHITE-developer opened this issue Oct 25, 2024 · 5 comments
Assignees
Labels
issue Something isn't working correctly

Comments

@WHITE-developer
Copy link

What happened?

When a admin notification has multiple recipients, and you are using a files template, only the first sends out.
Seems that the template mode is switched to early here https://github.com/solspace/craft-freeform/blob/v5/packages/plugin/src/Services/MailerService.php#L151. Moving the switch outside the foreach works.

image

Errors and Stack Trace (if available)

No response

How can we reproduce this?

See above

Freeform Edition

Pro

Freeform Version

5.6.7

Craft Version

Craft Pro 4.12.8

When did this issue start?

After upgrading from older Freeform version, After upgrading from older Craft version

Previous Freeform Version

4.x

@WHITE-developer WHITE-developer added the issue Something isn't working correctly label Oct 25, 2024
@kjmartens
Copy link
Contributor

Hi @WHITE-developer,

I tried testing this on my end, and I can't seem to get it to fail. I wonder if there's another factor here. I'll have a developer check into it and see what they think. 🙂

@WHITE-developer
Copy link
Author

I'm also sending via the queue, maybe that's something.

@WHITE-developer
Copy link
Author

@kjmartens any update on this?

@kjmartens
Copy link
Contributor

Sorry for the delay @WHITE-developer.

I have queued this for a developer to check into shortly. I should likely have an update for you by tomorrow (Friday). 🙂

@kjmartens
Copy link
Contributor

This should be resolved now in Freeform 5.7.0 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue Something isn't working correctly
Development

No branches or pull requests

3 participants