Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New LazyLoad feature does not play well with dynamic title. #298

Closed
PolarbearDK opened this issue Oct 5, 2017 · 5 comments
Closed

New LazyLoad feature does not play well with dynamic title. #298

PolarbearDK opened this issue Oct 5, 2017 · 5 comments
Labels

Comments

@PolarbearDK
Copy link
Contributor

PolarbearDK commented Oct 5, 2017

First of all, kudos to the new lazy load feature. Great stuff!

There is however a problem if you have the following options

{
    fixedTitle: false, 
    dynamicTitleMaxItems: 2, // Any value greater than 0 (0 is a workaround).
    isLazyLoad: true,
}

The problem is that only the selected items that is visible right now is displayed in the dynamic title.

Reproduced using Lazy loading Plunker:

  • set msSettings.fixedTitle = false
  • Run plunker and check first two countries
  • Search for "cuba"

The dynamic title is now blank.

@softsimon softsimon added the bug label Oct 5, 2017
@softsimon
Copy link
Owner

@GregKass

@GregKass
Copy link
Contributor

GregKass commented Oct 9, 2017

@softsimon @PolarbearDK: How important is the title ordering in this case? Case in point: Assume that the countries aren't necessarily alphabetically ordered, and are possibly arbitrarily ordered. You load the first twenty and check one. Then you search on countries containing "b", and scroll down a few loads and select another. Then you search on "c", scroll again, and select a third. How do you know where the first selection, second selection (b), and third selection (c) sit relative to one another? The first case is easy because it contains all selections, but where do "b" and "c" sit relative to one another if you've scrolled beyond the cases with no search applied? You could possibly match cases that contain both "b" and "c" to map reference points, but this would only narrow things down a little. Would titles displaying in the order selected be acceptable? Maybe you could arrange them in the proper order when the selected titles have been loaded in without using a search parameter?

@PolarbearDK
Copy link
Contributor Author

I don't think title ordering is important. It would be fine to display in the order they were selected.

@gund
Copy link
Collaborator

gund commented Oct 9, 2017

+1 for the selection order. Seems reasonable =)

@softsimon
Copy link
Owner

Should be fixed now in v1.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants