Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update failing tests notifications #1667

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

agatakrajewska
Copy link
Contributor

@agatakrajewska agatakrajewska commented Jun 2, 2023

Description

Sending the failed ACC tests notifications to slack rather than Discord

Tested in CI by pushing a failing job.

@agatakrajewska agatakrajewska requested a review from a team as a code owner June 2, 2023 10:58
@agatakrajewska agatakrajewska requested review from craigfurman and removed request for a team June 2, 2023 10:58
@agatakrajewska agatakrajewska force-pushed the update-failing-tests-notifications branch from 5539b39 to 8987686 Compare June 2, 2023 12:17
Copy link
Contributor

@craigfurman craigfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@craigfurman
Copy link
Contributor

Maybe squash these commit though, since there is understandably no more temp testing job

@agatakrajewska agatakrajewska force-pushed the update-failing-tests-notifications branch from 8987686 to 3c8814f Compare June 2, 2023 12:27
@agatakrajewska agatakrajewska merged commit 7f729dc into main Jun 5, 2023
@agatakrajewska agatakrajewska deleted the update-failing-tests-notifications branch June 5, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants