Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support fuse in FutureExt #100

Closed
GlenDC opened this issue May 2, 2024 · 3 comments · Fixed by #101
Closed

support fuse in FutureExt #100

GlenDC opened this issue May 2, 2024 · 3 comments · Fixed by #101

Comments

@GlenDC
Copy link
Contributor

GlenDC commented May 2, 2024

Recently I switched from futures and futures-util to futures-lite. For the most case this was okay.

The only thing I did miss was the fuse functionality.

I implemented it here https://github.com/plabayo/rama/blob/main/src/future.rs.
Could I implement it in the actual futures-lite codebase.
Or what do you suggest?
@GlenDC
Copy link
Contributor Author

GlenDC commented May 2, 2024

If accepted I am willing to make a PR FWIW.

@GlenDC
Copy link
Contributor Author

GlenDC commented May 7, 2024

@notgull is there any interest for this?

@notgull
Copy link
Member

notgull commented May 7, 2024

Sorry, this fell through the cracks. Yes, I think this could be added, since it can't be trivially emulated with async blocks.

@GlenDC GlenDC mentioned this issue May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add Fuse support to FutureExt GlenDC/futures-lite
2 participants
@GlenDC @notgull