From 96c9e4de869e4bf2ded6562aa9d5a8c29a498eda Mon Sep 17 00:00:00 2001 From: Pierre Krieger Date: Sun, 25 Jun 2023 11:38:53 +0200 Subject: [PATCH 1/2] Remove `authoringVersion` field from runtime spec --- lib/src/json_rpc/methods.rs | 3 --- light-base/src/json_rpc_service/background/chain_head.rs | 1 - wasm-node/CHANGELOG.md | 4 ++++ 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/src/json_rpc/methods.rs b/lib/src/json_rpc/methods.rs index 8af916cd72..37852e5b68 100644 --- a/lib/src/json_rpc/methods.rs +++ b/lib/src/json_rpc/methods.rs @@ -1018,15 +1018,12 @@ pub struct RuntimeSpec<'a> { pub spec_name: Cow<'a, str>, #[serde(rename = "implName")] pub impl_name: Cow<'a, str>, - #[serde(rename = "authoringVersion")] - pub authoring_version: u32, #[serde(rename = "specVersion")] pub spec_version: u32, #[serde(rename = "implVersion")] pub impl_version: u32, #[serde(rename = "transactionVersion", skip_serializing_if = "Option::is_none")] pub transaction_version: Option, - // TODO: add `state_version`? would need a JSON-RPC API interface spec change pub apis: HashMap, } diff --git a/light-base/src/json_rpc_service/background/chain_head.rs b/light-base/src/json_rpc_service/background/chain_head.rs index eb4de51d02..eaeba758f2 100644 --- a/light-base/src/json_rpc_service/background/chain_head.rs +++ b/light-base/src/json_rpc_service/background/chain_head.rs @@ -448,7 +448,6 @@ fn convert_runtime_spec( spec_name: runtime.spec_name.into(), impl_version: runtime.impl_version, spec_version: runtime.spec_version, - authoring_version: runtime.authoring_version, transaction_version: runtime.transaction_version, apis: runtime .apis diff --git a/wasm-node/CHANGELOG.md b/wasm-node/CHANGELOG.md index a265604a32..31e189d55e 100644 --- a/wasm-node/CHANGELOG.md +++ b/wasm-node/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +### Changed + +- The runtime specification yielded by the `chainHead_unstable_follow` JSON-RPC function no longer includes the `authoringVersion` field, in accordance with the latest changes in the JSON-RPC API specification. ([#814](https://github.com/smol-dot/smoldot/pull/814)) + ### Fixed - Fix not absorbing the JavaScript exception triggered by the browser when connecting to a `ws://` node when smoldot is embedded in a web page served over `https://`. ([#795](https://github.com/smol-dot/smoldot/pull/795), [#800](https://github.com/smol-dot/smoldot/pull/800)) From 605d36bf874748a439be1f354bf113b711da7803 Mon Sep 17 00:00:00 2001 From: Pierre Krieger Date: Sun, 25 Jun 2023 11:39:14 +0200 Subject: [PATCH 2/2] PR link --- wasm-node/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wasm-node/CHANGELOG.md b/wasm-node/CHANGELOG.md index 31e189d55e..51becac279 100644 --- a/wasm-node/CHANGELOG.md +++ b/wasm-node/CHANGELOG.md @@ -4,7 +4,7 @@ ### Changed -- The runtime specification yielded by the `chainHead_unstable_follow` JSON-RPC function no longer includes the `authoringVersion` field, in accordance with the latest changes in the JSON-RPC API specification. ([#814](https://github.com/smol-dot/smoldot/pull/814)) +- The runtime specification yielded by the `chainHead_unstable_follow` JSON-RPC function no longer includes the `authoringVersion` field, in accordance with the latest changes in the JSON-RPC API specification. ([#815](https://github.com/smol-dot/smoldot/pull/815)) ### Fixed