Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestsSubscriptions should provide some kind of NotificationsSend object #408

Closed
tomaka opened this issue Apr 11, 2023 · 1 comment
Closed

RequestsSubscriptions should provide some kind of NotificationsSend object #408

tomaka opened this issue Apr 11, 2023 · 1 comment
Labels
priority-low

Comments

@tomaka
Copy link
Contributor

tomaka commented Apr 11, 2023 •
edited
Loading

In order to avoid accidentally introducing cyclic references (cc #406), the RequestsSubscriptions code should provide a way to send a notifications through an object separate from itself.
This means that subscription tasks would no longer need to hold an Arc<RequestsSubscriptions>.
@tomaka
Copy link
Contributor Author

tomaka commented Jul 3, 2023

Irrelevant after #793

@tomaka tomaka closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaka