catch connect error

[turuslan]

Deno does not allow unhandled promise rejection and terminates with error: Uncaught (in promise).

Added .catch to Deno.connect.

It calls config.onConnectionReset, like WebSocket (success is .onopen (then may .onerror) then .onclose, failure is .onerror then .onclose).

[github-actions]

twiggy diff report

Difference in .wasm size before and after this pull request.

---

 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

[tomaka]

Thanks!

[tomaka]

Can connec actually be null/undefined here? I feel like the only way that this could happen is if reset was called twice, which would be a smoldot bug

[turuslan]

I returned null when Deno.connect returns error, so added this null-check

[tomaka]

Ah I see, I had to re-read the documentation of Promise.catch to understand

I'm trying very hard to not lose track of what's happening, which can very easily happen with JavaScript.
Given that reset should never be called after onConnectionReset, this should never be null, so:

Suggested change

	connection.socket.inner.then((connec) => connec?.close());
	connection.socket.inner.then((connec) => connec!.close());

[tomaka]

Could you maybe move this as the second parameter of the then below?
This would guarantee that the first closure of the then never gets a null

Also:

Suggested change

	}).catch((error) => {
	socket.destroyed = true;
	config.onConnectionReset(error.toString());
	return null!;
	}).catch((error) => {
	socket.destroyed = true;
	config.onConnectionReset(error.toString());
	return null;

[turuslan]

That first closure (and .send too) checks socket.destroyed, so doesn't use null.

Either null! is required, or change of type to TcpConnection { socket(inner: Promise<Deno.TcpConn | null>) }

[tomaka]

or change of type to TcpConnection { socket(inner: Promise<Deno.TcpConn | null>) }

Well, yes, that option.
As far as I understand, null! lies to the type checker. It's an escape hatch for situations where TypeScript isn't good enough, and not something you're supposed to use normally.

[tomaka]

I've pushed commits doing the change I've requested, plus a CHANGELOG entry

[tomaka]

Thanks!