Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build the chain information of parachains #908

Closed
tomaka opened this issue Jul 13, 2023 · 2 comments · Fixed by #1034
Closed

Don't build the chain information of parachains #908

tomaka opened this issue Jul 13, 2023 · 2 comments · Fixed by #1034

Comments

@tomaka
Copy link
Contributor

tomaka commented Jul 13, 2023

The light client currently builds the chain information of parachains.
This is a very CPU-heavy operation, and all the chain information is used for is determine the genesis runtime hash.

@tomaka
Copy link
Contributor Author

tomaka commented Aug 11, 2023

This turns out to not really be possible. Calculating the genesis hash requires knowing the state trie root, which in turn requires extracting the state version from the runtime.

Opened #1017 instead.

@tomaka tomaka closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2023
@tomaka tomaka reopened this Aug 15, 2023
@tomaka
Copy link
Contributor Author

tomaka commented Aug 15, 2023

Calculating the genesis hash requires knowing the state trie root, which in turn requires extracting the state version from the runtime.

I don't know what was in my mind, but the state trie root can be found directly in the chain spec, that was actually the entire point of the issue.

Reopening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant