Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wasm64 for the wasm node when available #88

Open
tomaka opened this issue Feb 9, 2023 · 1 comment
Open

Use wasm64 for the wasm node when available #88

tomaka opened this issue Feb 9, 2023 · 1 comment
Labels
blocked Progress on this issue requires something beyond our control

Comments

@tomaka
Copy link
Contributor

tomaka commented Feb 9, 2023

paritytech/smoldot#1789

@tomaka tomaka added the blocked Progress on this issue requires something beyond our control label Feb 10, 2023
@tomaka
Copy link
Contributor Author

tomaka commented Aug 16, 2023

I tried compiling for wasm64-unknown-unknown by curiosity.

The code of smoldot compiles just fine (after #1041) with -Z build-std=core,panic_abort,std, except for the fact that getrandom must be substituted with manually calling a binding function.
However when running with node --experimental-wasm-memory64, I get a weird error:

Error while adding chain: CompileError: WebAssembly.compile(): Compiling function #19:"_ZN7smoldot6libp2p10read_write21ReadWrite$LT$TN..." failed: memory.copy[2] expected type i32, found local.get of type i64 @+14623

I don't know whether this is a bug in NodeJS or a miscompilation, but in both cases wasm64 doesn't seem completely ready yet, and it's outside of our control.

@tomaka tomaka changed the title Use wasm64 for the wasmnode when available Use wasm64 for the wasm node when available Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Progress on this issue requires something beyond our control
Projects
None yet
Development

No branches or pull requests

1 participant