Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable some Wasm features when compiling the wasm node #350

Closed
tomaka opened this issue Mar 27, 2023 · 3 comments
Closed

Enable some Wasm features when compiling the wasm node #350

tomaka opened this issue Mar 27, 2023 · 3 comments
Labels
blocked Progress on this issue requires something beyond our control

Comments

@tomaka
Copy link
Contributor

tomaka commented Mar 27, 2023

bulk-memory comes to mind, but there might be others.

Of course, the blocker is that all major browsers should support a feature before it can be enabled.
@tomaka tomaka mentioned this issue Mar 28, 2023
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Mar 28, 2023

#356 enables bulk-memory and signext.

The two others that would be appropriate are:

  • simd128. Unfortunately, this is only supported by NodeJS 16.4, which I feel is a bit too recent.
  • multivalue. Enabling this one crashes rustc.

@tomaka tomaka added the blocked Progress on this issue requires something beyond our control label Mar 28, 2023
@tomaka tomaka mentioned this issue Apr 6, 2023
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Apr 24, 2023

multivalue. Enabling this one crashes rustc.

It seems that rustc no longer crashes, but I'm getting linking errors between the std library and my code, due to the fact that the standard library that is shipped with rustup isn't compiled with this option.

@tomaka
Copy link
Contributor Author

tomaka commented May 2, 2023

Overall, multivalue doesn't seem important in our case, so I'm going to close this issue as completed.

@tomaka tomaka closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Progress on this issue requires something beyond our control
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaka