Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parachain parent-child relationship confusions #1811

Open
tomaka opened this issue May 2, 2024 · 0 comments
Open

Parachain parent-child relationship confusions #1811

tomaka opened this issue May 2, 2024 · 0 comments

Comments

@tomaka
Copy link
Contributor

tomaka commented May 2, 2024

Smoldot currently treats parachain blocks as opaque. It tries to decode them, but if it fails everything continues anyway.

Due to this, it makes the assumption that if relayChainBlock1 is the parent of relayChainBlock2, then parahead(relayChainBlock1) is also the parent of parahead(relayChainBlock2).

I think that this might not necessarily be the case, for example if the relay chain stalls.

Unfortunately, figuring out the parent of a block requires decoding it, which, again, might not be possible.
We could in principle have 2 code paths: one where parents are always correct if blocks are decodable, and one where they're not necessarily. But I don't think that this is the best idea, because this behaviour is surprising, and that blocks might become undecodable in case of breaking change.

@tomaka tomaka changed the title Parachain parent-child-relationship confusions Parachain parent-child relationship confusions May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant