Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warp sync assertion failed #1497

Closed
tomaka opened this issue Dec 20, 2023 · 2 comments · Fixed by #1498
Closed

Warp sync assertion failed #1497

tomaka opened this issue Dec 20, 2023 · 2 comments · Fixed by #1498

Comments

@tomaka
Copy link
Contributor

tomaka commented Dec 20, 2023

thread 'main' panicked at /Users/tomaka/Projets/smoldot/lib/src/sync/warp_sync.rs:637:9:
assertion failed: self.sources.len() >= self.sources_by_finalized_height.len()
@tomaka
Copy link
Contributor Author

tomaka commented Dec 20, 2023

Problem is that we set the finalized_block_height field of a source to Err without removing it from sources_by_finalized_height.

@tomaka
Copy link
Contributor Author

tomaka commented Dec 20, 2023

Now that #1482 is done, we should remove this banning system altogether.

@tomaka tomaka mentioned this issue Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove banning system from warp_sync.rs and optimistic.rs tomaka/smoldot
1 participant
@tomaka