feature/race-control-chime #188
Conversation
uses settingsStore to store the setting. compares time of message to local time to determine if message is older than when the user went on the website. gives every message a id so that it isnt played twice.
|
@Ellodev is attempting to deploy a commit to the f1-dash Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| setValue: (value: number) => void; | ||
| }; | ||
|
|
||
| export default function Input({ value, setValue }: Props) { |
There was a problem hiding this comment.
As this Input has custom code for numbers, maybe it would be a good idea to either call it numeric input or move the numeric logic to where its used, what do you think is best?
There was a problem hiding this comment.
I'm thinking we could maybe call it something like PercentageInput since its defined as a Maximum of 100, and used for Percentages. Do you agree or would you rather that I move the Number logic somewhere else to make it more reusable?
There was a problem hiding this comment.
I think we go for Input for now and move the number logic to the settings page where we update the store
… feature/race-control-chime
uses settingsStore to store the setting.
compares time of message to local time to determine if message is older than when the user went on the website. gives every message a id so that it isnt played twice.