Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbind the Service Provider from the main code #7

Closed
akrabat opened this issue Jun 8, 2015 · 1 comment
Closed

Unbind the Service Provider from the main code #7

akrabat opened this issue Jun 8, 2015 · 1 comment

Comments

@akrabat
Copy link
Member

akrabat commented Jun 8, 2015

From slimphp/Slim#1275 (comment):

Can we stop coupling the ServiceProvider with the actual code for the package. I see this is becoming a pattern that others will follow. Now that we are using Container Interop, we shouldn't bind the actual package to the Pimple ServiceProviderInterface, we should create a separate class in each package to do this.

@silentworks
Copy link
Member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants