-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Celluloid support next to EventMachine #5
Comments
I'll add Celluloid support, as I have in the other gem. Two things though.
|
@digitalextremist are you saying we should replace Faraday for httprb? I would be open to it, but I am not sure it matters for slack-ruby-client given that HTTP communication is hardly the overhead. |
Correct, it is unrelated to the |
I'm really interested in this. Is there a way I could help? |
Please contribute @mikz! |
I'd like not to clash on some ongoing work. I plan to make a prototype using just celluloid-io and websocket-driver without using reel-io. |
@dblock @digitalextremist I did a prototype. See the code in dblock@ced303d. It successfully connected to slack and was answering with celluloid. The celluloid integration is probably not very correct. It crashes on Ctrl-C. What I'd like to do next:
|
This is very good. I actually think this whole code should be a gem that abstracts various ways of doing concurrency. |
Closing via https://github.com/dblock/slack-ruby-client/pull/26. Please try Celluloid support on HEAD. |
See https://github.com/abstractive/slack-ruby-gem/commit/41a45ba11a11c087b501654a159e72f27526dd9d.
The text was updated successfully, but these errors were encountered: