Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnecting task errors don't identify the worker #266

Closed
dblock opened this issue Apr 25, 2019 · 0 comments · Fixed by #284
Closed

Reconnecting task errors don't identify the worker #266

dblock opened this issue Apr 25, 2019 · 0 comments · Fixed by #284

Comments

@dblock
Copy link
Collaborator

dblock commented Apr 25, 2019

In a bot that uses slack-ruby-bot you get:

W, [2019-04-25T01:42:09.948060 #220]  WARN -- <Async::Task:0x28a05a0 connected to #<Addrinfo: 18.207.50.150:443 TCP (cerberus-xxxx.lb.slack-msgs.com)> running>: The operation has been cancelled!
I, [2019-04-25T01:42:10.101832 #220]  INFO -- : Successfully connected team XYZ (TXYZ) to https://xyz.slack.com.

The first error doesn't say that this team that has disconnected is XYZ.

The code on hello is https://github.com/slack-ruby/slack-ruby-bot/blob/1708693843487f1c1f97765d0d7ebbda1ef34d24/lib/slack-ruby-bot/hooks/hello.rb#L12, we need an event on disconnect to log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant