Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor monorepo support #150

Open
sksat opened this issue Jul 8, 2023 · 4 comments
Open

Refactor monorepo support #150

sksat opened this issue Jul 8, 2023 · 4 comments
Assignees
@sksat
Labels
enhancement New feature or request

Comments

@sksat
Copy link
Owner

sksat commented Jul 8, 2023

@sksat sksat added the enhancement New feature or request label Jul 8, 2023
@sksat sksat self-assigned this Jul 8, 2023
@sksat
Copy link
Owner Author

sksat commented Jul 8, 2023

  • 案1: repository top に設定ファイルを置く
    • これは .compose-cd とは分けるべき？（monorepo なら repository top に compose.yml なくない？）
    • commit の更新は repository top の設定ファイルで面倒見る
    • 個々のプロジェクトの面倒（再起動）はその中で別途やる
  • 案2: monorepo を検知してよしなにやる
    • repository top に project がなければ .git と並列してなければ，で済む

@sksat
Copy link
Owner Author

sksat commented Jul 8, 2023

（自分は使ってないが）tag 固定のみのユースケースの場合はそもそも Git 管理してなくてもええんでは，などもある

@sksat
Copy link
Owner Author

sksat commented Jul 8, 2023

monorepo でも image tag 固定のみの場合は commit の更新と合わせる必要はややないな（そういう挙動が欲しいことは無い気がするが......）

@sksat
Copy link
Owner Author

sksat commented Jul 8, 2023

update_image を捨てれば実装がだいぶシンプルになるんだよな......

@sksat sksat mentioned this issue Sep 18, 2023
Open
@sksat sksat added this to compose-cd Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sksat sksat

Labels
enhancement New feature or request
Projects
compose-cd
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sksat