Using pkg_resources makes package load really slow

[chrisjsewell]

Heya, this change really hurts package loading times 😬

shortuuid/shortuuid/__init__.py

Line 13 in bcd01ce

__version__ = pkg_resources.get_distribution("shortuuid").version

For example, with our CLI this change has meant an increase in load time from ~0.3 seconds to ~0.8 seconds!

pkg_resources is essentially deprecated, in part, for this very reason; replaced by https://docs.python.org/3/library/importlib.metadata.html and the https://github.com/python/importlib_metadata backport

[skorokithakis]

Hey @chrisjsewell, thanks for this! I mixed up the old and new methods :( Can you check the latest master and see that it works properly?

[chrisjsewell]

Thanks for the quick reply, I haven't check the timing yet, but I would note that using importlib.metadata will mean your package no longer supports python<3.8. Is that what you want?

[skorokithakis]

Oof, no, I didn't notice the version... Do I need to use the backport then?

[chrisjsewell]

Yep use the backport 👍 and also you can just do importlib_metadata.version("shortuuid")

[chrisjsewell]

also, the error to catch is importlib_metadata.PackageNotFoundError

[skorokithakis]

Hm, right. Given the frequency with which this library changes, I'm just going to type the version in by hand :P

[chrisjsewell]

Haha yep that's good by me!
(with setuptools or flit, you can just have the version read from the init and you don't have to put it in the pyproject.toml/setup.cfg)

[skorokithakis]

But I want it in the pyproject.toml, as it's easier for my deployment tooling to parse :/ Too bad, thanks for your help though!

[socketpair]

pypa/setuptools#926