Fix regression for issue #1526 regarding onFirstCall().throws() #1530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fix #1526 by adding
exceptionCreator
to the list of fields checked inisPresent
Background (Problem in detail) - optional
The PR #1511 broke this behavior because it added
exceptionCreator
as a field which stored a function which would create the exception.Solution - optional
The check was added in
isPresent
so that the behavior is detected as being set.How to verify - mandatory
If you run the new test on master it should fail, and it should pass on this branch.
Checklist for author
npm run lint
passes