Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove better-regex rule from recommended list #2409

Closed
fregante opened this issue Jul 25, 2024 · 2 comments · Fixed by #2443
Closed

Remove better-regex rule from recommended list #2409

fregante opened this issue Jul 25, 2024 · 2 comments · Fixed by #2443

Comments

@fregante
Copy link
Collaborator

fregante commented Jul 25, 2024

The rule uses a package "Published 7 years ago" https://www.npmjs.com/package/clean-regexp and it's the source of a lot of issues. Currently open:

Then check out regexp-tree issues

I disable it rather often, I suggest removing it from the recommended list or dropping/extracting the rule altogether.

@voxpelli
Copy link
Contributor

voxpelli commented Oct 23, 2024

Is the plan for better-regex to:

  1. Keep it around as is
  2. Keep it around and maintain it, possibly even making it recommended again in the future if it gets more reliable
  3. To deprecate it and remove it in a future version

#2443 mentions eslint-plugin-regex as a better alternative, but its unclear to me what a replacement for better-regex would look like with that module.

@voxpelli
Copy link
Contributor

Found typescript-eslint/typescript-eslint#9948 which seems to suggest that https://github.com/gmullerb/eslint-plugin-regex is not the correct module, its the https://github.com/ota-meshi/eslint-plugin-regexp that's a better replacement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants