-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Copy Image
option
#79
Add Copy Image
option
#79
Conversation
The implementation here is more complicated than I'd like. I think you instead should open an issue on https://github.com/electron/electron about adding an API to create a native image directly from an URL. They already have all the Chrome machinery to download images, so it would be better if they could handle it. Could be |
19186d0
to
75836cb
Compare
75836cb
to
690ff63
Compare
690ff63
to
0cb711c
Compare
I think you could have spent more time on perfecting this PR. At this point, it would have been much faster for me to just implement it myself. |
Sorry about that, I’ll do better on future PRs. |
You still need to do https://github.com/sindresorhus/electron-context-menu/pull/79/files#r312071329 |
@sindresorhus
This PR follows up on sindresorhus/caprine#943.
A couple of mentions:
png
orjpg
images. I tried withwebp
, for example, butelectron.nativeImage
has no support for it. I suppose we could convert topng
orjpg
.. thoughts?file://
protocol or notrequest
module for fetching the image bufferThanks!