-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add menu
option
#44
Add menu
option
#44
Conversation
I don't really see the point of this. If you override click, you might as well just create your own menu item. |
I've also removed this. Initially I added it with the idea of users maybe don't want to deal with "when should a menu item be visible" depending on the context. |
Any update on this PR? |
@jarivo I'm really sorry I never got around to merging this. It just got lost in all my tabs... I'm willing to prioritize reviewing it now if you fix the merge conflict, if not, no worries either. |
I'm happy to help out fixing the merge conflicts 😄 |
@jarivo |
@JoniVR |
Pr/44 merge conflicts resolved
TODO
|
This PR "fixes" both #14 and #43
So basically the user can now:
menu
-property in the configuration to override the default menu structuretransform
-function to the predefined actions in order to manipulate e.g. the data that will be copied to the clipboardOverride theclick
method. This will not work in combination with the transform so if you want to override the default click handler then you're basically on your own.The menuItem itself will determine wheter it should be visible or not. (Although this should be easy to implement when needed)
append
andprepend
should still work as expected. Although they now have an extra argument with the default actions.I've changed the fixture to represent the new features.
TODO
Fixes #14
Fixes #43