Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to round to a specific decimal place #64

Closed
silentmatt opened this issue Jan 17, 2017 · 2 comments · Fixed by #111
Closed

Add a function to round to a specific decimal place #64

silentmatt opened this issue Jan 17, 2017 · 2 comments · Fixed by #111

Comments

@silentmatt
Copy link
Owner

Basically the second half of #34 but separate from the round operator, which can't realistically support more than one operand.

@silentmatt silentmatt added this to the 1.1 milestone Jan 17, 2017
@silentmatt silentmatt modified the milestones: 1.2, 1.1 Aug 30, 2017
@marwahaha
Copy link
Contributor

Hi @silentmatt - it'd be great to have this. I'm ok building this but I noticed #34 already exists. Could I help out?

@silentmatt
Copy link
Owner Author

@marwahaha Sure, go for it. #34 is from before some major code reorganizations and changes so it can't be merged directly, but the implementation could be used as a starting point.

One thing to keep in mind is that the current round(x) "function" is actually an operator. The differences are subtle, and might go away eventually, but the bottom line is that for now, a two-argument version needs to be a separate function. I would probably go with roundTo, but I'm open to other suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants