Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Deneb to 1.4.0-beta.2 (devnet-9) #4735

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Update Deneb to 1.4.0-beta.2 (devnet-9) #4735

merged 7 commits into from
Sep 25, 2023

Conversation

dapplion
Copy link
Collaborator

@dapplion dapplion commented Sep 14, 2023 •
edited by michaelsproul
Loading

Proposed Changes

Additional Info

@michaelsproul
Copy link
Member

@dapplion I'm going to get this PR passing the tests and merge it 👍

@michaelsproul michaelsproul changed the title Add MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT Update Deneb to 1.4.0-beta.2 Sep 20, 2023
@michaelsproul michaelsproul added the work-in-progress PR is a work-in-progress label Sep 20, 2023
@michaelsproul
Copy link
Member

This is still WIP, I need to do some more massaging of the EF fork choice tests.

@michaelsproul michaelsproul changed the title Update Deneb to 1.4.0-beta.2 Update Deneb to 1.4.0-beta.2 (devnet-9) Sep 21, 2023
@michaelsproul
Copy link
Member

I've got the EF tests passing now. Ready for review

@michaelsproul michaelsproul added ready-for-review The code is ready for review backwards-incompat Backwards-incompatible API change and removed work-in-progress PR is a work-in-progress labels Sep 21, 2023
ethDreamer
ethDreamer approved these changes Sep 22, 2023
View reviewed changes
consensus/types/src/chain_spec.rs
@@ -686,6 +688,8 @@ impl ChainSpec {
config_name: None,
max_committees_per_slot: 4,
target_committee_size: 4,
min_per_epoch_churn_limit: 2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was scratching my head for a while over this one, wondering why so many tests were failing on the new spec 😅

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 25, 2023
@michaelsproul michaelsproul merged commit 5c5afaf into sigp:deneb-free-blobs Sep 25, 2023
29 checks passed
realbigsean added a commit to realbigsean/lighthouse that referenced this pull request Sep 25, 2023
@realbigsean
Revert "Update Deneb to 1.4.0-beta.2 (devnet-9) (sigp#4735)"
97035d5 
This reverts commit 5c5afaf.
@michaelsproul michaelsproul mentioned this pull request Jan 8, 2024
Merged
@dapplion dapplion deleted the max-activation-churn branch January 21, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul left review comments

@jimmygchen jimmygchen jimmygchen left review comments

@ethDreamer ethDreamer ethDreamer approved these changes

Assignees
No one assigned
Labels
backwards-incompat Backwards-incompatible API change deneb ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dapplion @michaelsproul @jimmygchen @ethDreamer