Fuzz test fixes related to pre_key_id and archived sessions count #521
+19
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514
Adopts idea from #514 about limiting the sum
me.archive_count + them.archive_count < 40
. Seems reasonable that any session archive by A would require B to archive a session state if those new messages are received.I also observed some failures where either
pre_key_id == 0
or duplicatepre_key_id
would confuse the message decryption.The consumption of random numbers in
process_pre_key
is kept in case there are pre-existing corpora that rely on that behavior. Could probably be eliminated...