Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML encoded entities aren't unescaped in link preview #5397

Closed
1 task done
jsoref opened this issue Jul 12, 2021 · 0 comments · Fixed by #5412
Closed
1 task done

HTML encoded entities aren't unescaped in link preview #5397

jsoref opened this issue Jul 12, 2021 · 0 comments · Fixed by #5412

Comments

@jsoref
Copy link

jsoref commented Jul 12, 2021 •
edited
Loading

  • I have searched open and closed issues for duplicates

Bug Description

HTML escaped characters in link previews aren't escaped.

Steps to Reproduce

  1. Open a message to someone
  2. In the message area, type something https://github.com/github/docs/pull/8135
  3. Wait for the link preview to arrive
  4. Send
  5. Look at the link preview

Actual Result

Raw HTML escaped entities:
What's

For reference, here's the line of HTML as seen by Chome's view-source:

What's being changed:

Expected Result

Decoded HTML entities:
What's

Screenshots

GitHub page as rendered in Google Chrome
image

Link preview as rendered in Signal
image

Platform Info

Signal Version: v5.8.0

Operating System: macOS Big Sur 11.4 (20F71)

Linked Device Version:

Link to Debug Log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unescape HTML encoded entities in link preview heysujal/Signal-Desktop
1 participant
@jsoref