Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tips: Should I continue to use svg-loader with vue-inline-svg? #11

Closed
bolducke opened this issue Mar 12, 2020 · 2 comments
Closed

Tips: Should I continue to use svg-loader with vue-inline-svg? #11

bolducke opened this issue Mar 12, 2020 · 2 comments

Comments

@bolducke
Copy link

Hey,

I was asking myself. I start using svg-loader with Vue-cli, but it miss some key feature like dynamic rendering(as you do in this package). Are you aware of benefits to use svg-loader if I'm using your package?

Very nice work btw. This package should receive more attention than vue-simple-svg.

@shrpne
Copy link
Owner

shrpne commented Mar 12, 2020

Thank you!

I think you should choose what approach you prefer.
Svg-loader inlines svg into markup. No dynamic requests are needed but markup size grows.
Vue-inline-svg works opposite. Markup stays clean. But you have to wait for images to load.

So maybe you can combine them in the way, that some images can be inlined and some can be loaded asynchronously.

@shrpne shrpne closed this as completed Mar 23, 2020
@Tragio
Copy link

Tragio commented Dec 30, 2020

Just want to left here a reminder. You can always preload the .svg that you need so you can download them faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants