Skip to content
This repository has been archived by the owner on Nov 4, 2020. It is now read-only.

Is it time to deprecate Object.prototype extension? #146

Open
naugtur opened this issue Jun 20, 2017 · 1 comment
Open

Is it time to deprecate Object.prototype extension? #146

naugtur opened this issue Jun 20, 2017 · 1 comment

Comments

@naugtur
Copy link

naugtur commented Jun 20, 2017

There's more and more changes like this: nodejs/node#6055
where objects no longer inherit from Object.prototype

Is it time to deprecate this feature in favor of a global variable or something like that?

Feel free to close this if you're tired of discussing Object.prototype, I understand.

Node.js version?

6

Should.js version?

any

How to reproduce it?

try asserting on the result of querystring.parse()

@btd
Copy link
Member

btd commented Jun 20, 2017

Hi, i am good with this disscussion. But Object.prototype method is not required at all, just call require('should/as-function') it you will have should without Object.prototype extension.
I do not see any reason for doing this deprecation now, users should just stop using it eventually after such changes and after this i can remove object.prototype extension safe and easy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants