fix: Fix framerate autodetection edge case #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariocynicys
approved these changes
Nov 3, 2022
hmishinev
reviewed
Nov 3, 2022
| # float. | ||
| fraction = frame_rate_string.split('/') | ||
| fraction = frame_rate_string.split('|')[0].split('/') |
There was a problem hiding this comment.
@joeyparrish, sorry for the late comment, but I observed the same issue for the resolution_string too.
Traceback (most recent call last):
File "/usr/local/bin/shaka-streamer", line 126, in <module>
sys.exit(main())
File "/usr/local/bin/shaka-streamer", line 105, in main
with controller.start(args.output, input_config_dict, pipeline_config_dict,
File "/Users/hmishinev/Projects/Reedsy/shaka-streamer/streamer/controller_node.py", line 179, in start
self._input_config = InputConfig(input_config_dict)
File "/Users/hmishinev/Projects/Reedsy/shaka-streamer/streamer/input_configuration.py", line 405, in __init__
super().__init__(dictionary)
File "/Users/hmishinev/Projects/Reedsy/shaka-streamer/streamer/configuration.py", line 325, in __init__
value = self._check_and_convert_type(field, key, value)
File "/Users/hmishinev/Projects/Reedsy/shaka-streamer/streamer/configuration.py", line 381, in _check_and_convert_type
return [self._check_and_convert_type(subfield, key, v) for v in value]
File "/Users/hmishinev/Projects/Reedsy/shaka-streamer/streamer/configuration.py", line 381, in <listcomp>
return [self._check_and_convert_type(subfield, key, v) for v in value]
File "/Users/hmishinev/Projects/Reedsy/shaka-streamer/streamer/configuration.py", line 368, in _check_and_convert_type
sub_object = field.type(value)
File "/Users/hmishinev/Projects/Reedsy/shaka-streamer/streamer/input_configuration.py", line 248, in __init__
self.resolution = autodetect.get_resolution(self)
File "/Users/hmishinev/Projects/Reedsy/shaka-streamer/streamer/autodetect.py", line 156, in get_resolution
width_string, height_string = resolution_string.split('|')
ValueError: too many values to unpack (expected 2)
There was a problem hiding this comment.
Since I don't have the content that is triggering this, can you please fork and send a PR that resolves all autodetect issues for you?
There was a problem hiding this comment.
@joeyparrish, #129 addresses all the issues that I met.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127