Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ads): Fix bad static overlay ad position #7735

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 10, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Dec 10, 2024
@avelad avelad requested review from theodab and tykus160 December 10, 2024 13:32
@avelad avelad added this to the v4.13 milestone Dec 10, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad avelad merged commit e4825c3 into shaka-project:main Dec 10, 2024
21 of 22 checks passed
@avelad avelad deleted the ad-bad-position branch December 10, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants