Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ads): Fix unnecessary request when using VAST #7660

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 25, 2024

If the URL does not have an extension, using mimeType allows us to avoid having to make a HEAD type request

If the URL does not have an extension, using mimeType allows us to avoid having to make a HEAD type request
@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Nov 25, 2024
@avelad avelad added this to the v4.13 milestone Nov 25, 2024
@avelad avelad merged commit d09cd7e into shaka-project:main Nov 25, 2024
22 of 23 checks passed
@avelad avelad deleted the vast-extra-request branch November 25, 2024 16:28
avelad added a commit that referenced this pull request Nov 27, 2024
If the URL does not have an extension, using mimeType allows us to avoid
having to make a HEAD type request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants