Configurable IdentityMap #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The identity map is now exposed as a global and can be disabled:
Twitter.identity_map = false
Likewise, it can be replaced by a custom implementation:
Twitter.identity_map = My::Custom::SqliteIdentityMap
| end | ||
| end | ||
|
|
||
| # Alias for backwards compatability | ||
| class << self | ||
| alias fetch_or_new fetch_or_create | ||
| alias fetch_or_create fetch_or_new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes based on our discussions in #285 and #286 the identity map is now a global on the Twitter module and can be disabled or replaced. I've also switched back to
fetch_or_new, I left an alias tofetch_or_createinTwitter::Basethough it may not be necessary if the changes from my previous PR have not been released.