Skip to content

Commit

Permalink
Swapped the roauth dependency for simple_oauth.
Browse files Browse the repository at this point in the history
  • Loading branch information
laserlemon authored and sferik committed Oct 12, 2010
1 parent 1d69561 commit 76cfe37
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 6 deletions.
5 changes: 3 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ PATH
addressable (~> 2.2.1)
faraday (~> 0.4.1)
faraday_middleware (~> 0.1.1)
roauth (~> 0.0.3)
simple_oauth (~> 0.1.0)

GEM
remote: http://rubygems.org/
Expand Down Expand Up @@ -37,6 +37,7 @@ GEM
rake (0.8.7)
roauth (0.0.3)
shoulda (2.11.3)
simple_oauth (0.1.0)
test-unit (2.1.1)
yard (0.6.1)

Expand All @@ -53,8 +54,8 @@ DEPENDENCIES
json_pure (~> 1.4)
mocha (~> 0.9)
rake (~> 0.8)
roauth (~> 0.0.3)
shoulda (~> 2.11)
simple_oauth (~> 0.1.0)
test-unit (~> 2.1)
twitter!
yard (~> 0.6)
2 changes: 1 addition & 1 deletion lib/twitter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
require 'faraday'
require 'faraday_middleware'
require 'forwardable'
require 'roauth'
require 'simple_oauth'
require 'cgi'

module Twitter
Expand Down
3 changes: 2 additions & 1 deletion lib/twitter/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,8 @@ def oauth_header(path, options, method)
:access_key => self.access_key,
:access_secret => self.access_secret
}
ROAuth.header(oauth_params, connection.build_url(path), options, method)
SimpleOAuth::Header.new(method, connection.build_url(path), options, oauth_params).to_s
#ROAuth.header(oauth_params, connection.build_url(path), options, method)

This comment has been minimized.

Copy link
@laserlemon

laserlemon Oct 12, 2010

Author Collaborator

Oops. I forgot to remove the commented-out ROAuth code.

end

def perform_get(path, options={})
Expand Down
3 changes: 2 additions & 1 deletion lib/twitter/geo.rb
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ def oauth_header(path, options, method)
:access_key => @access_key,
:access_secret => @access_secret
}
ROAuth.header(oauth_params, connection.build_url(path), options, method)
SimpleOAuth::Header.new(method, connection.build_url(path), options, oauth_params).to_s
#ROAuth.header(oauth_params, connection.build_url(path), options, method)

This comment has been minimized.

Copy link
@laserlemon

laserlemon Oct 12, 2010

Author Collaborator

And again.

end

end
Expand Down
2 changes: 1 addition & 1 deletion twitter.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Gem::Specification.new do |s|
s.add_runtime_dependency("addressable", "~> 2.2.1")
s.add_runtime_dependency("faraday", "~> 0.4.1")
s.add_runtime_dependency("faraday_middleware", "~> 0.1.1")
s.add_runtime_dependency("roauth", "~> 0.0.3")
s.add_runtime_dependency("simple_oauth", "~> 0.1.0")
s.authors = ["John Nunemaker", "Wynn Netherland", "Erik Michaels-Ober"]
s.description = %q{A Ruby wrapper for the Twitter REST and Search APIs.}
s.email = ["[email protected]"]
Expand Down

1 comment on commit 76cfe37

@sferik
Copy link
Owner

@sferik sferik commented on 76cfe37 Oct 12, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll cleanup the stray comments.

Please sign in to comment.