-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed that search was ignoring many options when making request. Stup…
…id mistake. Changed the tests to test stuff farther down the chain so this doesn't happen again.
- Loading branch information
1 parent
2da4913
commit 096d56e
Showing
3 changed files
with
24 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
096d56e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested the pagination of search results much? Unless I’m missing something, the twitter search functionality you have ignores the data that comes back from Twitter about the next_page and since_id you need to request next.
096d56e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t assume how you are going to use the pagination information. I return it and you can use that for another search but I haven’t taken the time to actually implement next page and such. Doesn’t seem like it would be super hard.