Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Parse format param in stream request for per-request transcoding #507

Open
gabeklavans opened this issue May 25, 2024 · 3 comments

Comments

@gabeklavans
Copy link

Right now, the format param is only used to detect the raw key, in which case it will just serve the raw file.

if format == "raw" {

However, it would be nice (and I believe in-spec) if this param could also be used to request the specific stream be transcoded into one of the available formats, such as mp3 or opus.

@sentriz
Copy link
Owner

sentriz commented May 25, 2024

i would love for this to be possible, but we need some extension to the spec for clients to list the availible formats. eg gonic might have opus, opus_rg, or later on some custom format the the user created. and clients can't know what the options are

@gabeklavans
Copy link
Author

Good point. This would probably be a sensible addition to OpenSubsonic. I might open a discussion there.

@sentriz
Copy link
Owner

sentriz commented May 25, 2024

nice thank you. also releated is #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants