[dotnet] Return back protected synchronous Execute method in WebDriver

SeleniumHQ · Jul 6, 2024 · f096422 · f096422
1 parent 425ed87
commit f096422
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/dotnet/src/webdriver/Remote/HttpCommandExecutor.cs b/dotnet/src/webdriver/Remote/HttpCommandExecutor.cs
@@ -153,10 +153,10 @@ public bool TryAddCommand(string commandName, CommandInfo info)
         }
 
         /// <summary>
-        /// Executes a command
+        /// Executes a command.
         /// </summary>
-        /// <param name="commandToExecute">The command you wish to execute</param>
-        /// <returns>A response from the browser</returns>
+        /// <param name="commandToExecute">The command you wish to execute.</param>
+        /// <returns>A response from the browser.</returns>
         public virtual Response Execute(Command commandToExecute)
         {
             return Task.Run(() => this.ExecuteAsync(commandToExecute)).GetAwaiter().GetResult();
@@ -165,8 +165,8 @@ public virtual Response Execute(Command commandToExecute)
         /// <summary>
         /// Executes a command as an asynchronous task.
         /// </summary>
-        /// <param name="commandToExecute">The command you wish to execute</param>
-        /// <returns>A task object representing the asynchronous operation</returns>
+        /// <param name="commandToExecute">The command you wish to execute.</param>
+        /// <returns>A task object representing the asynchronous operation.</returns>
         public virtual async Task<Response> ExecuteAsync(Command commandToExecute)
         {
             if (commandToExecute == null)

diff --git a/dotnet/src/webdriver/WebDriver.cs b/dotnet/src/webdriver/WebDriver.cs
@@ -572,14 +572,20 @@ internal Task<Response> InternalExecuteAsync(string driverCommandToExecute,
             return this.ExecuteAsync(driverCommandToExecute, parameters);
         }
 
-        internal Response Execute(string driverCommandToExecute,
+        /// <summary>
+        /// Executes a command with this driver.
+        /// </summary>
+        /// <param name="driverCommandToExecute">A <see cref="DriverCommand"/> value representing the command to execute.</param>
+        /// <param name="parameters">A <see cref="Dictionary{K, V}"/> containing the names and values of the parameters of the command.</param>
+        /// <returns>A <see cref="Response"/> containing information about the success or failure of the command and any data returned by the command.</returns>
+        protected virtual Response Execute(string driverCommandToExecute,
             Dictionary<string, object> parameters)
         {
             return Task.Run(() => this.ExecuteAsync(driverCommandToExecute, parameters)).GetAwaiter().GetResult();
         }
 
         /// <summary>
-        /// Executes a command with this driver .
+        /// Executes a command with this driver.
         /// </summary>
         /// <param name="driverCommandToExecute">A <see cref="DriverCommand"/> value representing the command to execute.</param>
         /// <param name="parameters">A <see cref="Dictionary{K, V}"/> containing the names and values of the parameters of the command.</param>