Skip to content

Commit

Permalink
Remove spelling mistake from the method name (#11051)
Browse files Browse the repository at this point in the history
Co-authored-by: vikas <Vikas Goel>
  • Loading branch information
f2008700 authored Sep 26, 2022
1 parent 760305b commit cb8872c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions py/selenium/webdriver/remote/remote_connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def _identify_http_proxy_auth(self):
url = url[url.find(":") + 3:]
return "@" in url and len(url[:url.find('@')]) > 0

def _seperate_http_proxy_auth(self):
def _separate_http_proxy_auth(self):
url = self._proxy_url
protocol = url[:url.find(":") + 3]
no_protocol = url[len(protocol):]
Expand All @@ -156,7 +156,7 @@ def _get_connection_manager(self):
from urllib3.contrib.socks import SOCKSProxyManager
return SOCKSProxyManager(self._proxy_url, **pool_manager_init_args)
elif self._identify_http_proxy_auth():
self._proxy_url, self._basic_proxy_auth = self._seperate_http_proxy_auth()
self._proxy_url, self._basic_proxy_auth = self._separate_http_proxy_auth()
pool_manager_init_args['proxy_headers'] = urllib3.make_headers(
proxy_basic_auth=self._basic_proxy_auth)
return urllib3.ProxyManager(self._proxy_url, **pool_manager_init_args)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def test_get_proxy_url_none(mock_proxy_settings_missing):
def test_get_proxy_url_http_auth(mock_proxy_auth_settings):
remote_connection = RemoteConnection('http://remote', keep_alive=False)
proxy_url = remote_connection._get_proxy_url()
raw_proxy_url, basic_auth_string = remote_connection._seperate_http_proxy_auth()
raw_proxy_url, basic_auth_string = remote_connection._separate_http_proxy_auth()
assert proxy_url == "http://user:password@http_proxy.com:8080"
assert raw_proxy_url == "http://http_proxy.com:8080"
assert basic_auth_string == "user:password"
Expand All @@ -81,7 +81,7 @@ def test_get_proxy_url_http_auth(mock_proxy_auth_settings):
def test_get_proxy_url_https_auth(mock_proxy_auth_settings):
remote_connection = RemoteConnection('https://remote', keep_alive=False)
proxy_url = remote_connection._get_proxy_url()
raw_proxy_url, basic_auth_string = remote_connection._seperate_http_proxy_auth()
raw_proxy_url, basic_auth_string = remote_connection._separate_http_proxy_auth()
assert proxy_url == "https://user:password@https_proxy.com:8080"
assert raw_proxy_url == "https://https_proxy.com:8080"
assert basic_auth_string == "user:password"
Expand Down

0 comments on commit cb8872c

Please sign in to comment.