Skip to content

Commit

Permalink
Remove require of websocket in selenium-devtools gem (#10868)
Browse files Browse the repository at this point in the history
* Remove require of websocket with selenium-devtools gem and add runtime dependency for selenium-webdriver

In e89eb1 the dependency of websocket was moved from devtools.rb to websocket_connection.rb. This broke the selenium-devtools gem while Selenium 4.2 was not yet released. It was temporarily fixed in #10414. When using Selenium 4.2+ it is again no longer needed to be required in devtools.rb.
  • Loading branch information
kevindew authored Jul 13, 2022
1 parent 989c564 commit bb23fba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 0 additions & 2 deletions rb/lib/selenium/devtools.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
# specific language governing permissions and limitations
# under the License.

require 'websocket'

module Selenium
module DevTools
class << self
Expand Down
2 changes: 2 additions & 0 deletions rb/selenium-devtools.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,6 @@ Gem::Specification.new do |s|
] + Dir['lib/selenium/devtools/**/*']

s.require_paths = ["lib"]

s.add_runtime_dependency 'selenium-webdriver', '~> 4.2'
end

0 comments on commit bb23fba

Please sign in to comment.