Skip to content

Commit

Permalink
[js] Bump the min supported version of Node to 4.2 (the LTS)
Browse files Browse the repository at this point in the history
Also updating the policy on Node support moving forward.

Fixes #1280
  • Loading branch information
jleyba committed Jan 16, 2016
1 parent af60554 commit 9318a4b
Show file tree
Hide file tree
Showing 3 changed files with 60 additions and 1 deletion.
10 changes: 10 additions & 0 deletions javascript/node/selenium-webdriver/CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
## v2.49.0-dev

### Notice

Starting with v2.49.0, each release of selenium-webdriver will support the
latest _minor_ LTS and stable Node releases. All releases between the LTS and
stable release will have best effort support. Further details are available in
the selenium-webdriver package README.

### Change Summary

* Bumped the minimum supported version of Node to v4.2.x
* Added `promise.Promise#catch()` for API compatibility with native Promises.
`promise.Promise#thenCatch()` is not yet deprecated, but it simply
delegates to `catch`.
Expand Down
49 changes: 49 additions & 0 deletions javascript/node/selenium-webdriver/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,54 @@ Contributions are accepted either through [GitHub][gh] pull requests or patches
via the [Selenium issue tracker][issues]. You must sign our
[Contributor License Agreement][cla] before your changes will be accepted.

## Node Support Policy

Each version of selenium-webdriver will support the latest _semver-minor_
version of the [LTS] and stable Node releases. All _semver-major_ &
_semver-minor_ versions between the LTS and stable release will have "best
effort" support. Following a Selenium release, any _semver-minor_ Node releases
will also have "best effort" support. Releases older than the latest LTS,
_semver-major_ releases, and all unstable release branches (e.g. "v.Next")
are considered strictly unsupported.

For example, suppose the current LTS and stable releases are v4.2.4 and v5.4.1,
respectively. Then a Selenium release would have the following support levels:

| Version | Support |
| ------- | ------------- |
| <= 4.1 | _unsupported_ |
| 4.2 | supported |
| 5.0-3 | best effort |
| 5.4 | supported |
| >= 5.5 | best effort |
| v.Next | _unsupported_ |

### Support Level Definitions

- _supported:_ A selenium-webdriver release will be API compatible with the
platform API, without the use of runtime flags.

- _best effort:_ Bugs will be investigated as time permits. API compatibility is
only guaranteed where required by a _supported_ release. This effectively
means the adoption of new JS features, such as ES2015 modules, will depend
on what is supported in Node's LTS.

- _unsupported:_ Bug submissions will be closed as will-not-fix and API
compatibility is not guaranteed.

### Projected Support Schedule

If Node releases a new [LTS] each October and a new major version every 6
months, the support window for selenium-webdriver will be roughly:

| Date | LTS | Stable |
| --------- | ---: | -----: |
| (current) | 4.2 | 5.0 |
| 2016-04 | 4.2 | 6.0 |
| 2016-10 | 6.0 | 7.0 |
| 2017-04 | 6.0 | 8.0 |
| 2017-10 | 8.0 | 9.0 |

## Issues

Please report any issues using the [Selenium issue tracker][issues]. When using
Expand Down Expand Up @@ -164,6 +212,7 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.

[LTS]: https://github.com/nodejs/LTS
[api]: http://seleniumhq.github.io/selenium/docs/api/javascript/
[cla]: http://goo.gl/qC50R
[chrome]: http://chromedriver.storage.googleapis.com/index.html
Expand Down
2 changes: 1 addition & 1 deletion javascript/node/selenium-webdriver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"url": "https://github.com/SeleniumHQ/selenium.git"
},
"engines": {
"node": ">= 0.12.x"
"node": ">= 4.2.x"
},
"dependencies": {
"adm-zip": "0.4.4",
Expand Down

0 comments on commit 9318a4b

Please sign in to comment.