[rb] Use no-sandbox on non-Windows

This is required on RBE which runs Docker linux
SeleniumHQ · May 2, 2024 · 8d94b34 · 8d94b34
1 parent f54ba8b
commit 8d94b34
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
@@ -250,13 +250,15 @@ def safari_preview_driver(**opts)
         def chrome_options(args: [], **opts)
           opts[:binary] ||= ENV['CHROME_BINARY'] if ENV.key?('CHROME_BINARY')
           args << '--headless=chrome' if ENV['HEADLESS']
+          args << '--no-sandbox' if ENV['NO_SANDBOX']
           args << '--disable-gpu'
           WebDriver::Options.chrome(browser_version: 'stable', args: args, **opts)
         end
 
         def edge_options(args: [], **opts)
           opts[:binary] ||= ENV['EDGE_BINARY'] if ENV.key?('EDGE_BINARY')
           args << '--headless=chrome' if ENV['HEADLESS']
+          args << '--no-sandbox' if ENV['NO_SANDBOX']
           args << '--disable-gpu'
           WebDriver::Options.edge(browser_version: 'stable', args: args, **opts)
         end

diff --git a/rb/spec/tests.bzl b/rb/spec/tests.bzl
@@ -30,6 +30,9 @@ BROWSERS = {
         }) | select({
             "@selenium//common:use_headless_browser": {"HEADLESS": "true"},
             "//conditions:default": {},
+        }) | select({
+            "@platforms//os:windows": {},
+            "//conditions:default": {"NO_SANDBOX": "true"},
         }),
     },
     "edge": {
@@ -53,6 +56,9 @@ BROWSERS = {
         }) | select({
             "@selenium//common:use_headless_browser": {"HEADLESS": "true"},
             "//conditions:default": {},
+        }) | select({
+            "@platforms//os:windows": {},
+            "//conditions:default": {"NO_SANDBOX": "true"},
         }),
     },
     "firefox": {