Skip to content

Commit

Permalink
we should not be swallowing exceptions in the teardown for driver.qui…
Browse files Browse the repository at this point in the history
…t in python

This is what lead me to believe (falsely) that the refactoring for the driver service was working
references #1469
  • Loading branch information
lukeis committed Jan 14, 2016
1 parent 0e9269c commit 8c0e81b
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions py/test/selenium/webdriver/browser_specific_template.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,10 @@ class ##BROWSER_SPECIFIC_TEST_CLASS##(##GENERAL_FILENAME##.##GENERAL_TEST_CLASS#


def teardown_module(module):
try:
##BROWSER_SPECIFIC_TEST_CLASS##.driver.quit()
except AttributeError:
pass
try:
##BROWSER_SPECIFIC_TEST_CLASS##.webserver.stop()
except AttributeError:
pass

##BROWSER_SPECIFIC_TEST_CLASS##.driver.quit()
##CUSTOM_TEST_TEARDOWN##

0 comments on commit 8c0e81b

Please sign in to comment.