Make sure the fix doesn't break IE

Changed bot.action.clear so it still explicitly raise Blur event on IE. Modified test case testClearingANonEmptyElement to assert blur event is raised exactly once after bot.action.clear is called. Signed-off-by: Alexei Barantsev <[email protected]>
SeleniumHQ · Apr 28, 2019 · 87efe1b · 87efe1b
1 parent 127b282
commit 87efe1b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/javascript/atoms/action.js b/javascript/atoms/action.js
@@ -98,6 +98,9 @@ bot.action.clear = function(element) {
       element.value = '';
     }
     bot.events.fire(element, bot.events.EventType.CHANGE);
+    if (goog.userAgent.IE) {
+      bot.events.fire(element, bot.events.EventType.BLUR);
+    }
     var body = bot.getDocument().body;
     if (body) {
       bot.action.LegacyDevice_.focusOnElement(body);

diff --git a/javascript/atoms/test/action_test.html b/javascript/atoms/test/action_test.html
@@ -56,6 +56,9 @@
           });
     }
 
+    var expectBlurEvent = goog.partial(expectEvent,
+        goog.events.EventType.BLUR);
+
     var expectChangeEvent = goog.partial(expectEvent,
         goog.events.EventType.CHANGE);
 
@@ -68,6 +71,9 @@
           count, counts[eventType]);
     }
 
+    var assertBlurFired = goog.partial(assertEventFired,
+        goog.events.EventType.BLUR);
+
     var assertChangeFired = goog.partial(assertEventFired,
         goog.events.EventType.CHANGE);
 
@@ -113,8 +119,10 @@
         e.value = 'foobar';
         e.disabled = false;
         e.readOnly = false;
+        expectBlurEvent(e);
         expectChangeEvent(e);
         bot.action.clear(e);
+        assertBlurFired();
         assertChangeFired();
         assertEquals('', e.value);
       });