Skip to content

Commit

Permalink
[js] fix SeleniumServer.start() crashes on MacOS with nodejs selenium…
Browse files Browse the repository at this point in the history
…-webdriver (#12158)

* [js] use generated selenium manager artifacts for testing

* #12076 fix

---------

Co-authored-by: titusfortner <[email protected]>
Co-authored-by: Diego Molina <[email protected]>
  • Loading branch information
3 people authored Jun 9, 2023
1 parent 505abc3 commit 7cfd137
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions javascript/node/selenium-webdriver/remote/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,7 @@ function getJavaPath() {
function isSelenium3x(seleniumStandalonePath) {
const javaPath = getJavaPath()

const execRes = cp.execSync(
`${javaPath} -jar ${seleniumStandalonePath} --version`
)
const execRes = cp.execFileSync(javaPath, ['-jar', seleniumStandalonePath, '--version'])

return execRes.toString().trim().startsWith('Selenium server version: 3')
}
Expand Down

0 comments on commit 7cfd137

Please sign in to comment.