Skip to content

Commit

Permalink
Deleting fail-fast check of browser configuration, this breaks anothe…
Browse files Browse the repository at this point in the history
…r Grid dependency on parts of RC server. The check must be performed in RC server (if ever).
  • Loading branch information
barancev committed Oct 13, 2015
1 parent 8fba765 commit 7c99758
Showing 1 changed file with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import org.openqa.selenium.remote.CapabilityType;
import org.openqa.selenium.remote.DesiredCapabilities;
import org.openqa.selenium.remote.JsonToBeanConverter;
import org.openqa.selenium.server.browserlaunchers.BrowserLauncherFactory;

import com.google.common.collect.Maps;
import com.google.gson.Gson;
Expand Down Expand Up @@ -380,13 +379,6 @@ public static RegistrationRequest build(String... args) {
res.loadFromCommandLine(args);

for (DesiredCapabilities cap : res.capabilities) {
if (SeleniumProtocol.Selenium.toString().equals(cap.getCapability(SELENIUM_PROTOCOL))) {
if (!BrowserLauncherFactory.isBrowserSupported(cap.getBrowserName())) {
throw new GridConfigurationException("browser " + cap.getBrowserName()
+ " is not supported, supported browsers are:\n"
+ BrowserLauncherFactory.getSupportedBrowsersAsString());
}
}
if (cap.getCapability(SELENIUM_PROTOCOL) == null) {
cap.setCapability(SELENIUM_PROTOCOL,
GridRole.isRC(nodeType)
Expand Down

0 comments on commit 7c99758

Please sign in to comment.